Skip to content

PackageToJS: Use the actual wasm filename in the final product #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2025
Merged

PackageToJS: Use the actual wasm filename in the final product #303

merged 3 commits into from
Mar 17, 2025

Conversation

kateinoigakukun
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 17, 2025 •
edited
Loading

Time Change: -30ms (0%)

Total Time: 9,606ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import with int 22ms -2ms (8%) ✅
View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import 25ms +1ms
Serialization/JavaScript function call from Swift 129ms +5ms (3%)
Serialization/Swift Int to JavaScript with assignment 337ms +3ms (0%)
Serialization/Swift Int to JavaScript with call 963ms -11ms (1%)
Serialization/JavaScript Number to Swift Int 272ms +1ms
Serialization/Swift String to JavaScript with assignment 419ms +2ms (0%)
Serialization/Swift String to JavaScript with call 1,043ms -10ms (0%)
Serialization/JavaScript String to Swift String 3,598ms -10ms (0%)
Object heap/Increment and decrement RC 2,784ms -7ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 3ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 3ms
Serialization/Call with JavaScript string directly 3ms

@kateinoigakukun kateinoigakukun marked this pull request as ready for review March 17, 2025 08:05
@kateinoigakukun kateinoigakukun merged commit 1a33c51 into main Mar 17, 2025
5 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/module-name branch March 17, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kateinoigakukun